Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in RunCmdWithOutputParser #41

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Race condition in RunCmdWithOutputParser #41

merged 5 commits into from
Nov 30, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Nov 28, 2023 •
edited by yahavi
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'

@eranturgeman eranturgeman added the bug Something isn't working label Nov 28, 2023
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

yahavi
yahavi requested changes Nov 28, 2023
View reviewed changes
io/cmd.go Outdated Show resolved Hide resolved
io/cmd.go Outdated Show resolved Hide resolved
@yahavi yahavi changed the title Race condition in RunCmdWithOutputParser fix Race condition in RunCmdWithOutputParser Nov 29, 2023
@yahavi
Copy link
Member

yahavi commented Nov 29, 2023 •
edited
Loading

  • Fix race condition in RunCmdWithOutputParser
  • Update Go to 1.20
  • Move Command struct from build-info-go

Dependency for jfrog/build-info-go#216 & jfrog/jfrog-cli-core#1053

This was referenced Nov 29, 2023
Merged
Merged
attiasas
attiasas reviewed Nov 30, 2023
View reviewed changes
Copy link

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! please consider my comments

io/cmd.go Outdated Show resolved Hide resolved
io/cmd_test.go Outdated Show resolved Hide resolved
io/cmd_test.go Outdated Show resolved Hide resolved
@yahavi yahavi merged commit 6d742be into jfrog:dev Nov 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas left review comments

@yahavi yahavi yahavi requested changes

Assignees

@yahavi yahavi

@eranturgeman eranturgeman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eranturgeman @yahavi @attiasas